test: select random free server ports with 0 #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-select-server-ports-with-0-in-tests
branch
from
8c8bc67
to
82726da
Compare
The previous port selection algorithm relied on port range. The range was from 48700 to 49000. This is 300 ports of which some may be already reserved in the system running tests. The free ports are allocated between the pytest workers. With 4 workers there is 75 ports for each. This causes flakiness in the tests as ports may not be available or are still in wait after previous tests. In the test environment it is not necessary to select ports from IANA dynamic port assignment range. Any free port is ok and port 0 can be used for dynamically allocated free port.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-select-server-ports-with-0-in-tests
branch
from
82726da
to
3e2202e
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
nosahama
reviewed
Sep 24, 2024
| @@ -15,8 +14,15 @@ | |||
| import socket | |||
|
|
|||
|
|
|||
| @contextmanager | |||
| def allocate_port_no_reuse() -> Iterator[int]: | |||
There was a problem hiding this comment.
[nit-pick]
Maybe Generator[int] as the return type, since you already did earlier, but doesn't hurt as generators as also iterators.
nosahama
reviewed
Sep 24, 2024
| def allocate_port_no_reuse() -> Iterator[int]: | ||
| """Allocate random free port and do not allow reuse.""" | ||
| with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock: | ||
| sock.bind(("127.0.0.1", 0)) |
There was a problem hiding this comment.
If host or port are ‘’ or 0 respectively the OS default behavior will be used.
Simpler and nice 👍
nosahama
reviewed
Sep 24, 2024
| """Allocate random free port.""" | ||
| with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock: | ||
| sock.bind(("127.0.0.1", 0)) | ||
| sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) |
There was a problem hiding this comment.
The
SO_REUSEADDRflag tells the kernel to reuse a local socket inTIME_WAITstate, without waiting for its natural timeout to expire.
nosahama
approved these changes
Sep 24, 2024
nosahama
deleted the
jjaakola-aiven-select-server-ports-with-0-in-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
The previous port selection algorithm relied on port range. The range
was from 48700 to 49000. This is 300 ports of which some may be already
reserved in the system running tests. The free ports are allocated between
the pytest workers. With 4 workers there is 75 ports for each. This causes
flakiness in the tests as ports may not be available or are still in
wait after previous tests. In the test environment it is not necessary
to select ports from IANA dynamic port assignment range. Any free port
is ok and port 0 can be used for dynamically allocated free port.